Skip to content

fix(patch): cherry-pick d96bd05 to release/v0.30.0-preview.5-pr-19867 to patch version v0.30.0-preview.5 and create version 0.30.0-preview.6#20112

Merged
sehoon38 merged 1 commit into
release/v0.30.0-preview.5-pr-19867from
hotfix/v0.30.0-preview.5/0.30.0-preview.6/preview/cherry-pick-d96bd05/pr-19867
Feb 24, 2026
Merged

fix(patch): cherry-pick d96bd05 to release/v0.30.0-preview.5-pr-19867 to patch version v0.30.0-preview.5 and create version 0.30.0-preview.6#20112
sehoon38 merged 1 commit into
release/v0.30.0-preview.5-pr-19867from
hotfix/v0.30.0-preview.5/0.30.0-preview.6/preview/cherry-pick-d96bd05/pr-19867

Conversation

@gemini-cli-robot

@gemini-cli-robot gemini-cli-robot commented Feb 24, 2026

Copy link
Copy Markdown
Collaborator

This PR automatically cherry-picks commit d96bd05 to patch version v0.30.0-preview.5 in the preview release to create version 0.30.0-preview.6.

@gemini-cli-robot gemini-cli-robot requested a review from a team as a code owner February 24, 2026 01:31
@github-actions github-actions Bot mentioned this pull request Feb 24, 2026
Merged
18 tasks
@github-actions

github-actions Bot commented Feb 24, 2026

Copy link
Copy Markdown

You already have 7 pull requests open. Please work on getting existing PRs merged before opening more.

@github-actions github-actions Bot closed this Feb 24, 2026
@gemini-code-assist

gemini-code-assist Bot commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request provides a critical patch to ensure the application correctly identifies and grants access to the gemini-3.1-pro-preview model. It refactors the preview model detection logic within the Config class to be more robust and includes specific support for the new PREVIEW_GEMINI_3_1_CUSTOM_TOOLS_MODEL, alongside updated test coverage to validate these changes. This ensures users with access to this specific preview model are correctly recognized.

Highlights

  • Enhanced Preview Model Recognition: The Config class's quota retrieval logic now uses a generalized isPreviewModel function to determine access to preview models, rather than checking for a single specific model ID.
  • Added gemini-3.1-pro-preview Support: The isPreviewModel utility function has been updated to explicitly recognize PREVIEW_GEMINI_3_1_CUSTOM_TOOLS_MODEL as a valid preview model.
  • Improved Test Coverage: New test cases were introduced to verify that the system correctly identifies PREVIEW_GEMINI_3_1_CUSTOM_TOOLS_MODEL as a preview model and that hasAccessToPreviewModel is accurately set when gemini-3.1-pro-preview is present in the user's quota.
Changelog
  • packages/core/src/config/config.test.ts
    • Added a test case to verify that hasAccessToPreviewModel is set to true when the quota includes gemini-3.1-pro-preview.
  • packages/core/src/config/config.ts
    • Updated the retrieveUserQuota method to use the isPreviewModel helper function for checking if a model ID grants access to preview features.
  • packages/core/src/config/models.test.ts
    • Added a test to confirm isPreviewModel correctly identifies PREVIEW_GEMINI_3_1_CUSTOM_TOOLS_MODEL.
  • packages/core/src/config/models.ts
    • Included PREVIEW_GEMINI_3_1_CUSTOM_TOOLS_MODEL in the list of models recognized by the isPreviewModel function.
Activity
  • This pull request was automatically generated to cherry-pick commit d96bd05d368a7315fdf106a6de95e299d97adc18 into the release/v0.30.0-preview.5-pr-19867 branch, creating version 0.30.0-preview.6.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Feb 24, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cherry-picks a fix to correctly identify preview models when checking user quota. The changes generalize the preview model check in config.ts to use the isPreviewModel helper, and update this helper and its tests in models.ts to include the new gemini-3.1-pro-preview-customtools model. A new test is also added in config.test.ts to verify the updated logic. The changes are correct, well-tested, and improve the maintainability of the preview model access logic. I have no specific comments as the changes are solid.

@sehoon38 sehoon38 reopened this Feb 24, 2026
@github-actions

github-actions Bot commented Feb 24, 2026

Copy link
Copy Markdown

Size Change: +53 B (0%)

Total Size: 24.5 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 24.5 MB +53 B (0%)
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B

compressed-size-action

@sehoon38 sehoon38 enabled auto-merge (squash) February 24, 2026 01:39
@gemini-cli gemini-cli Bot added the status/need-issue Pull requests that need to have an associated issue. label Feb 24, 2026
@sehoon38 sehoon38 merged commit a24009f into release/v0.30.0-preview.5-pr-19867 Feb 24, 2026
33 of 51 checks passed
@sehoon38 sehoon38 deleted the hotfix/v0.30.0-preview.5/0.30.0-preview.6/preview/cherry-pick-d96bd05/pr-19867 branch February 24, 2026 01:57
kuishou68 pushed a commit to iOfficeAI/gemini-cli-pro that referenced this pull request Feb 27, 2026
@gemini-cli-robot @bdmorgan
fix(patch): cherry-pick d96bd05 to release/v0.30.0-preview.5-pr-19867…
1343f66 
… to patch version v0.30.0-preview.5 and create version 0.30.0-preview.6 (google-gemini#20112)

Co-authored-by: Bryan Morgan <bryanmorgan@google.com>
@sripasg sripasg added the size/s A small PR label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sehoon38 sehoon38 sehoon38 approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/s A small PR status/need-issue Pull requests that need to have an associated issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gemini-cli-robot @sehoon38 @sripasg @bdmorgan